Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JUnit Platform 1.10.0 #1159

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Support JUnit Platform 1.10.0 #1159

merged 1 commit into from
Sep 10, 2023

Conversation

hankem
Copy link
Member

@hankem hankem commented Aug 25, 2023

The new getAncestors() method in TestDescriptor (https://junit.org/junit5/docs/5.10.0/release-notes/)
was obviously not available in

class com.tngtech.archunit.junit.internal.AbstractArchUnitTestDescriptor
extends org.junit.platform.engine.support.descriptor.AbstractTestDescriptor

from org.junit.platform:junit-platform-engine:1.9.x.

Solves #1157

@hankem hankem requested a review from codecholeric August 25, 2023 20:04
@hankem hankem force-pushed the support-Junit-5.10 branch from 47d9cd1 to 5dc2bdb Compare August 26, 2023 10:24
@hankem hankem changed the title Upgrade JUnit to 5.10.0 / JUnit Platform to 1.10.0 Support JUnit Platform 1.10.0 Aug 26, 2023
The new `getAncestors()` method in `TestDescriptor` (https://junit.org/junit5/docs/5.10.0/release-notes/)
was obviously not available in
```
com.tngtech.archunit.junit.internal.AbstractArchUnitTestDescriptor
extends org.junit.platform.engine.support.descriptor.AbstractTestDescriptor
```
from `org.junit.platform:junit-platform-engine:1.9.x`.

Solves #1157

Signed-off-by: Manfred Hanke <[email protected]>
@codecholeric
Copy link
Collaborator

Ha, for the first time I remembered that we also have to adjust release_check/archunit-junit5-engine-api.pom 😂
But thanks a lot! I saw the other issue, I guess this is one of those classpath fun times, probably even changing the order of archunit-junit5 and jupiter in the Maven POM would have been sufficient to stop the problem if one is backwards compatible 🤪

@hankem hankem merged commit ed0eb93 into main Sep 10, 2023
21 checks passed
@hankem hankem deleted the support-Junit-5.10 branch September 10, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants